Skip to content

fix: Improve archive APIs to be able to link archives to actions#2095

Merged
gpeacock merged 11 commits into
mainfrom
mathern/archive-api
May 22, 2026
Merged

fix: Improve archive APIs to be able to link archives to actions#2095
gpeacock merged 11 commits into
mainfrom
mathern/archive-api

Conversation

@tmathern
Copy link
Copy Markdown
Contributor

@tmathern tmathern commented Apr 29, 2026

Changes in this pull request

The recently added archive APIs simplify the handling of ingredient archives, but there is a bug where when those APIs are used, two ingredients can't be linked to actions when a Builder signs (see test scenario test_two_ingredient_archives_link_distinctly_via_actions).

This fixes that.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@tmathern tmathern self-assigned this Apr 29, 2026
@tmathern tmathern changed the title fix: WIP fix: Improve archive APIs to be able to link archives to actions Apr 29, 2026
@tmathern tmathern requested review from gpeacock and ok-nick April 29, 2026 17:51
@tmathern tmathern marked this pull request as ready for review April 29, 2026 17:51
Comment thread sdk/src/builder.rs Outdated
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 21, 2026

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 64 skipped benchmarks1


Comparing mathern/archive-api (a2d66cb) with main (ff60e10)2

Open in CodSpeed

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (9fa52a3) during the generation of this report, so ff60e10 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Copy link
Copy Markdown
Collaborator

@scouten-adobe scouten-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion; otherwise 👍.

Comment thread sdk/src/builder.rs
@gpeacock gpeacock merged commit 35d5036 into main May 22, 2026
44 checks passed
@gpeacock gpeacock deleted the mathern/archive-api branch May 22, 2026 21:57
@caiopensrc caiopensrc mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants